Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.5 upgrade, loads of new linting #1351

Merged
merged 30 commits into from
Dec 23, 2021

Conversation

Stephen-ONeil
Copy link
Contributor

@Stephen-ONeil Stephen-ONeil commented Dec 22, 2021

#1350 re-pushed with CI-friendly branch name 🙄

Closes TBS-EACPD/infobase-archive#1179
Closes TBS-EACPD/infobase-archive#1196

TODO:

  • upgrade TS (and Prettier)
    • and eslint
      • ... and fix no-unused-vars rule, tons of linting for that
      • while I'm at it, better project wide linting script, lint everywhere
      • maybe a side-job in CI to check global linting, right now only client src code is actually regularly checked by CI
        • bonus, extended this job to check prettier and types as well, removed prettier from the local pre-push hook
  • Identify mixed JS/type imports, add type flags (see here)

@Stephen-ONeil Stephen-ONeil mentioned this pull request Dec 22, 2021
8 tasks
@Stephen-ONeil Stephen-ONeil changed the title Typescript 4.5 upgrade Typescript 4.5 upgrade, loads of new linting Dec 22, 2021
…and ts (warn, but ignore arguments starting with an _)
…ettier ignores. Simplifies running project-wide linting
…nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
…at's good because whatever I was trying with yaml fragments wasn't going to work, ha
…e non 0 exit status on warnings as well as errors too
…gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
…parate CI job now. Will revert this if it turns out to be an inconsiquential optimization
…antial optimization, safer/more convienient to not have the extra logic on it
Copy link
Contributor

@Steph-Rancourt Steph-Rancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, mostly just a CI job change and some linting (didn't look at all those files too too closely)

@Stephen-ONeil Stephen-ONeil merged commit 4275407 into master Dec 23, 2021
@Stephen-ONeil Stephen-ONeil deleted the typescript-four-point-five branch December 23, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants