-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript 4.5 upgrade, loads of new linting #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephen-ONeil
changed the title
Typescript 4.5 upgrade
Typescript 4.5 upgrade, loads of new linting
Dec 22, 2021
… for TS 4.5 support
…and ts (warn, but ignore arguments starting with an _)
…ettier ignores. Simplifies running project-wide linting
…nsistently used. Add all installs to project-wide lint job to make sure necessary eslint plugins are all installed (might not be worth having this centralized lint job afterall, hmm)
…at's good because whatever I was trying with yaml fragments wasn't going to work, ha
…e non 0 exit status on warnings as well as errors too
… people popuate code
…gotcha when left on the default false (and trying to fix a large numer of these quickly, ha)
Stephen-ONeil
force-pushed
the
typescript-four-point-five
branch
from
December 22, 2021 22:26
0cc71da
to
ab836e5
Compare
…alysis job, closes #1068
…parate CI job now. Will revert this if it turns out to be an inconsiquential optimization
…antial optimization, safer/more convienient to not have the extra logic on it
Steph-Rancourt
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, mostly just a CI job change and some linting (didn't look at all those files too too closely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1350 re-pushed with CI-friendly branch name 🙄
Closes TBS-EACPD/infobase-archive#1179
Closes TBS-EACPD/infobase-archive#1196
TODO:
no-unused-vars
rule, tons of linting for thattype
flags (see here)